Create doctrine messenger transport table on send #33559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create this table on send just like it is created on get to match the documentation and expectations for auto_setup.
Tobion
approved these changes
Sep 12, 2019
Contributor
Tobion
left a comment
Tobion
left a comment
There was a problem hiding this comment.
Could you delete the wrong comment in
please?auto-setup happens on get and send
Contributor
Author
|
@Tobion, yes. Deleted! |
Contributor
|
superseded in #32308 really (which i've not managed to finish off) |
Contributor
Author
|
Oh good @bendavies I was considering that as a next step, I'm glad you're already looking into it. Seems like this should still be merged as a bug fix for release to be enhanced when you finish up that PR? |
Member
|
Closing in favor of #32308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create doctrine messenger transport table on send just like it is created on get to match the
documentation and expectations for auto_setup.
Existing documentation at https://symfony.com/doc/current/messenger.html#doctrine-transport includes:
I think this is correct as I'd expect the table to be autocreated on set before get.
Tests are added here, but they don't actually fail correctly and I'm not sure why. I wonder if sqlite or doctrine is auto creating this table on insert when it isn't present. Maybe it's something else that you will see that I'm missing.