[WebProfilerBundle] Assign automatic colors to custom Stopwatch categories #33535
+75
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
WebProfilerBundle
Stopwatch
DX
Contributor
|
not a javascript expert at all, but 👍 for the feature, thank you! |
stof
approved these changes
Sep 10, 2019
yceruto
approved these changes
Sep 10, 2019
fabpot
approved these changes
Sep 10, 2019
fabpot
approved these changes
Sep 10, 2019
Member
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2019
…Stopwatch categories (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Assign automatic colors to custom Stopwatch categories | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33514 | License | MIT | Doc PR | not needed ### Before  ### After  - - - - - I'd appreciate reviews from JavaScript experts. Thanks! Commits ------- 329a74f [WebProfilerBundle] Assign automatic colors to custom Stopwatch categories
6 tasks
fabpot
added a commit
that referenced
this pull request
Sep 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Clean time.js | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The `classnames` property was removed in #33535. Commits ------- 997ca70 [WebProfilerBundle] Clean time.js
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Sep 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Clean time.js | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The `classnames` property was removed in symfony/symfony#33535. Commits ------- 997ca70385 [WebProfilerBundle] Clean time.js
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
I'd appreciate reviews from JavaScript experts. Thanks!