Fix gmail relay #33449
Merged
Fix gmail relay #33449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpolaszek
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
Member
|
@bpolaszek Something went wrong here. Can you push again? |
Contributor
Author
|
Wow |
Contributor
Author
|
Sorry, it looks like I rebased on 4.4 instead of 4.3 (bug fixes). It should be OK now. Sorry for that. AppVeyor fails but it doesn't seem related. |
fabpot
approved these changes
Sep 4, 2019
Member
|
Thank you @bpolaszek. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix gmail relay | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32148 | License | MIT This tiny PR fixes #32148 by removing the emission of a notice which prevented a `TransportException` to be thrown when something wrong occured. Commits ------- 6c90e08 Fix #32148 TransportException was not thrown
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR fixes #32148 by removing the emission of a notice which prevented a
TransportExceptionto be thrown when something wrong occured.