Skip to content

Conversation

@bohanwood
Copy link

Before this fix, bin/console about can't properly show Environment (.env) section because:
SYMFONY_DOTENV_VARS which stores all keys of Dotenv-set env vars, is being fetched via getenv().

However, in Symfony Dotenv 4.3, usage of putenv() is deprecated:
symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334
so we can get env vars via getenv() only when new Dotenv(true).
In the default shipped config/bootstrap.php, there is new Dotenv(false) set.

(Maybe related #29131)

Q A
Branch? 4.3 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 30, 2019
@fabpot
Copy link
Member

fabpot commented Aug 30, 2019

Thank you @brentybh.

fabpot added a commit that referenced this pull request Aug 30, 2019
…(brentybh)

This PR was squashed before being merged into the 4.3 branch (closes #33357).

Discussion
----------

[FrameworkBundle] Fix about command not showing .env vars

Before this fix, `bin/console about` can't properly show `Environment (.env)` section because:
`SYMFONY_DOTENV_VARS` which stores all keys of Dotenv-set env vars, is being fetched via `getenv()`.

However, in Symfony Dotenv 4.3, usage of `putenv()` is deprecated:
symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334
so we can get env vars via `getenv()` only when `new Dotenv(true)`.
In the default shipped `config/bootstrap.php`, there is `new Dotenv(false)` set.

(Maybe related #29131)

| Q             | A
| ------------- | ---
| Branch?       | 4.3 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

f48f19d [FrameworkBundle] Fix about command not showing .env vars
@fabpot fabpot merged commit f48f19d into symfony:4.3 Aug 30, 2019
@fabpot fabpot mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants