[Messenger] Added support for from_transport attribute on messenger.message_handler tag
#33317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2019
Member
|
@Nyholm what do you think about this proposal? Thanks. |
Nyholm
approved these changes
Sep 25, 2019
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I like this PR. I reviewed and tested it. It works as expected.
Thank you!
src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Sep 25, 2019
…r.message_handler` tag
fabpot
force-pushed
the
from-transport-via-tag-attribute
branch
from
7dd9b88 to
c965e4e
Compare
Member
|
Thank you @ruudk. |
Member
|
Wohoo! |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 9, 2019
…age_handler` tag (ruudk) This PR was squashed before being merged into the 4.4 branch (closes #12231). Discussion ---------- Explain how to add `from_transport` on `messenger.message_handler` tag See symfony/symfony#33317 Commits ------- 03ed48e Explain how to add `from_transport` on `messenger.message_handler` tag
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it's only possible to have dynamic
from_transportwhen usingMessageSubscriberInterface. Things likepriorityandbuscan already be added as attributes on the messenger.message_handler` tag.With this PR it now also supports
from_transport.