[DependencyInjection] Add types to private/final/internal methods and constructors #33266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Aug 20, 2019
derrabus
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32179, #33228 |
| License | MIT |
| Doc PR | NA/ |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
…hods (nicolas-grekas, derrabus) This PR was merged into the 4.4 branch. Discussion ---------- Add return types to tests and final|internal|private methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33228 #33236 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> #33266 made me spot an issue with my logic to add return types with help from `DebugClassLoader`. Here is a completing PR, with the logic expanded to test classes. I need help to fix tests, /cc @derrabus :) Commits ------- c39fd9c Fixed tests on the Security and Form components fc186bb Add return types to tests and final|internal|private methods
Member
|
Honestly, I'm not a big fan of adding |
Member
Author
Hey, I could have added As I already said on #33228, I might need a llittle guidance on when to add |
derrabus
force-pushed
the
improvement/dependency-injection-types
branch
from
c21fbb2 to
767023f
Compare
Member
:'D I did add them when a third-party dep encourages us to do so. I may have added more but I regret already :) |
sstok
reviewed
Aug 28, 2019
sstok
reviewed
Aug 28, 2019
src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/dependency-injection-types
branch
from
767023f to
fb74fbf
Compare
Member
Author
|
If you've heard someone weeping, it was probably me reverting all the |
derrabus
force-pushed
the
improvement/dependency-injection-types
branch
from
fb74fbf to
def0ac7
Compare
Member
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2019
…l methods and constructors (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Add types to private/final/internal methods and constructors | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179, #33228 | License | MIT | Doc PR | NA/ Commits ------- def0ac7 Add types to private/final/internal methods and constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.