[Translation] Fix docblock and ensure that preg_match isn't called on null #33247
Conversation
|
|
||
| /** | ||
| * @param string $locale The locale | ||
| * @param string|null $locale The locale |
There was a problem hiding this comment.
This doesn't look right to me. If we were to make this change, we would also have to change the return type of getLocale() which would break the contract of the TranslatorInterface.
There was a problem hiding this comment.
I think the interface is lying and needs to be fixed. That is what I wrote in #33154 (comment)
There was a problem hiding this comment.
I don't see a use case for a null locale. My suggestion is to deprecate support for this instead (see #33272).
There was a problem hiding this comment.
Now that support for passing null is to be removed in Symfony 5.0 I would revert the docblock changes and only keep the check for null below.
|
Closing, no need to do anything on 3.4, this has been dealt with on 4.4. Thanks. |
5 participants
#33154 (comment)