-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Serializer] Add more parameter types #33185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
Member
Author
|
I'm already in love with fabbot's new powers. /cc @tigitz |
41a5cac to
a66589c
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet :)
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
Show resolved
Hide resolved
8a6572f to
0b46c1a
Compare
dunglas
approved these changes
Aug 15, 2019
Tobion
approved these changes
Aug 15, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] Fixed docblocks and parameter names | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Backports from #33185. Commits ------- 50701fe [Serializer] Fixed docblocks and parameter names.
Member
|
Can be rebased |
0b46c1a to
25cc3f4
Compare
25cc3f4 to
73b17a8
Compare
Contributor
|
Thank you @derrabus. |
Tobion
added a commit
that referenced
this pull request
Aug 17, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Serializer] Add more parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154. Commits ------- 73b17a8 [Serializer] Add more parameter types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154.