Parameter type leftovers #33154
Merged
Parameter type leftovers #33154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/type-leftovers
branch
2 times, most recently
from
77f21ed to
772c6bb
Compare
Member
Author
|
Status: Needs Work |
derrabus
force-pushed
the
improvement/type-leftovers
branch
5 times, most recently
from
cfe451f to
35ae2ad
Compare
Tobion
reviewed
Aug 14, 2019
This was referenced Aug 15, 2019
derrabus
force-pushed
the
improvement/type-leftovers
branch
2 times, most recently
from
e2b2e5a to
8c60600
Compare
Member
Author
|
Status: Needs Review |
This was referenced Aug 16, 2019
Merged
src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/type-leftovers
branch
from
8c60600 to
89ef1df
Compare
derrabus
force-pushed
the
improvement/type-leftovers
branch
from
89ef1df to
f0426a6
Compare
Tobion
added a commit
that referenced
this pull request
Aug 17, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Serializer] Add more parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A We missed quite a lot in the Serializer, so I decided to open a separate PR instead of merging the changes into #33154. Commits ------- 73b17a8 [Serializer] Add more parameter types.
nicolas-grekas
added a commit
that referenced
this pull request
Aug 18, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Fix some docblocks | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Backports from #33154. Commits ------- df89373 Fix some docblocks.
derrabus
force-pushed
the
improvement/type-leftovers
branch
2 times, most recently
from
2e58c60 to
41f8ee6
Compare
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Add types to private and final methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Backports from #33154. Commits ------- 1b88067 Add types to private and final methods.
Member
|
rebase unlocked. |
derrabus
force-pushed
the
improvement/type-leftovers
branch
from
41f8ee6 to
ca86fc5
Compare
Member
Author
|
Ready. |
nicolas-grekas
approved these changes
Aug 19, 2019
Tobion
reviewed
Aug 19, 2019
derrabus
force-pushed
the
improvement/type-leftovers
branch
from
ca86fc5 to
d8493b8
Compare
derrabus
force-pushed
the
improvement/type-leftovers
branch
from
d8493b8 to
34eda04
Compare
Member
Author
|
Rebased. PR is ready. |
Tobion
approved these changes
Aug 21, 2019
Member
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Parameter type leftovers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Commits ------- 34eda04 Added more parameter type declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.