[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument #33131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Aug 12, 2019
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
The next step would be to add the \TypeError in master/5.0, no?
yceruto
reviewed
Aug 12, 2019
src/Symfony/Component/Form/ChoiceList/Factory/ChoiceListFactoryInterface.php
Outdated
Show resolved
Hide resolved
Contributor
Author
Yes, I will do that in #32237 |
vudaltsov
force-pushed
the
choice-list-factory-phpdoc-fix
branch
from
073c248 to
8f5d1ca
Compare
nicolas-grekas
approved these changes
Aug 13, 2019
Member
|
Thank you @vudaltsov. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2019
…teView $label argument (vudaltsov) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Add bool type to ChoiceListFactoryInterface::createView $label argument | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Replaces #33074 Ping @nicolas-grekas , @Tobion , @yceruto . Commits ------- 8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #33074
Ping @nicolas-grekas , @Tobion , @yceruto .