Skip to content

added Process::getLastOutputTime() method #33098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Aug 18, 2019
Merged

added Process::getLastOutputTime() method #33098

fabpot merged 1 commit into from
Aug 18, 2019

Conversation

@connorhu
Copy link
Contributor

@connorhu connorhu commented Aug 9, 2019

Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28026
License MIT
Doc PR -

@chalasr chalasr added this to the next milestone Aug 9, 2019
@chalasr chalasr added the Process label Aug 9, 2019
nicolas-grekas
nicolas-grekas reviewed Aug 11, 2019
View reviewed changes
derrabus
derrabus requested changes Aug 11, 2019
View reviewed changes
@derrabus
Copy link
Member

derrabus commented Aug 11, 2019

The PR should target the 4.4 branch.

Simperfit
Simperfit suggested changes Aug 12, 2019
View reviewed changes
fabpot
fabpot requested changes Aug 13, 2019
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Aug 18, 2019

Thank you @connorhu.

fabpot added a commit that referenced this pull request Aug 18, 2019
@fabpot
feature #33098 added Process::getLastOutputTime() method (connorhu)
eae614b 
This PR was squashed before being merged into the 5.0-dev branch (closes #33098).

Discussion
----------

added `Process::getLastOutputTime()` method

| Q             | A
| ------------- | ---
| Branch?       | 4.4 for features
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28026
| License       | MIT
| Doc PR        | -

Commits
-------

6359145 added `Process::getLastOutputTime()` method
@fabpot fabpot mentioned this pull request Aug 18, 2019
Closed
@fabpot fabpot merged commit 6359145 into symfony:master Aug 18, 2019
@OskarStark
Copy link
Contributor

OskarStark commented Aug 20, 2019

Why was this PR merged in master instead of 4.4?
The docs issue also mention 5.0-dev(which is correct, if master for the code is correct)

cc @nicolas-grekas

@fabpot
Copy link
Member

fabpot commented Aug 20, 2019

This was merged in master by mistake. I will cherry-pick the commit in 4.4. Thanks for the head up.

@OskarStark
Copy link
Contributor

OskarStark commented Aug 20, 2019

Thanks, I will update the docs issue accordingly 👍

@connorhu
Copy link
Contributor Author

connorhu commented Aug 21, 2019

Thank you @fabpot

I'll keep an eye out for similar simple issues.

@fabpot
Copy link
Member

fabpot commented Aug 21, 2019

@connorhu If you have access to an Amazon AWS EC2 machine, you might want to have a look a #33183, I think this is mainly about figuring out how to get the credentials from a local storage (having a look at the PHP SDK might be enough).

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@fabpot fabpot mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@derrabus derrabus derrabus requested changes

@fabpot fabpot fabpot approved these changes

+1 more reviewer

@Simperfit Simperfit Simperfit requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Process Status: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@connorhu @derrabus @fabpot @OskarStark @nicolas-grekas @Simperfit @chalasr @carsonbot