[HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt #33022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Aug 7, 2019
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #33017 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
approved these changes
Aug 7, 2019
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(failures unrelated)
We use the stream method internally, which also implements timeout management, but it reads network buffers before failing, which this option doesn't.
lyrixx
force-pushed
the
http-client-connect
branch
from
e1f9599 to
679ea90
Compare
nicolas-grekas
force-pushed
the
http-client-connect
branch
from
679ea90 to
e289723
Compare
Member
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
…rixx) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33017 | License | MIT | Doc PR | - Commits ------- e289723 [HttpClient] Remove CURLOPT_CONNECTTIMEOUT_MS curl opt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.