[Messenger] Don't deep-merge senders configuration #32970
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
sroze
approved these changes
Aug 18, 2019
Contributor
sroze
left a comment
sroze
left a comment
There was a problem hiding this comment.
Makes sense for the Messenger keys indeed. But shouldn't we do this in 4.4 only because it's still clearly a BC break?
Member
|
I agree that this should be for 4.4. |
nicolas-grekas
requested changes
Sep 6, 2019
chalasr
force-pushed
the
no-deep-merge
branch
from
53ea26e to
cbe197f
Compare
chalasr
changed the title
chalasr
force-pushed
the
no-deep-merge
branch
from
cbe197f to
976ebdf
Compare
chalasr
force-pushed
the
no-deep-merge
branch
from
976ebdf to
20d19ac
Compare
Member
Author
|
PR updated to only disable deep merging for the As @nicolas-grekas suggests, we need to discuss other parts of the config tree case by case, let's move forward on this one. |
lyrixx
approved these changes
Sep 13, 2019
Member
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Sep 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Don't deep-merge senders configuration | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32953 | License | MIT | Doc PR | - Commits ------- 20d19ac [Messenger] Don't deep merge routing.senders config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.