[Yaml] Removed unused $nullAsTilde property #32944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the property must be removed. The check on the flags must be kept in the dumpNull method. |
pierredup
changed the title
Member
|
Good catch, thanks @pierredup. |
xabbuh
added a commit
that referenced
this pull request
Aug 5, 2019
This PR was squashed before being merged into the 4.4 branch (closes #32944). Discussion ---------- [Yaml] Removed unused $nullAsTilde property | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A #32669 added a new private property `$nullAsTilde`, but that property was never used, so this PR removes the unused property Commits ------- fbef854 [Yaml] Removed unused $nullAsTilde property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32669 added a new private property
$nullAsTilde, but that property was never used, so this PR removes the unused property