[cs-fixer] Use PhpUnit native assertions in filsystem checks #32924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Aug 4, 2019
nicolas-grekas
approved these changes
Aug 4, 2019
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(please sync the PR title)
jderusse
changed the title
fabpot
approved these changes
Aug 5, 2019
Member
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
…ecks (jderusse) This PR was merged into the 3.4 branch. Discussion ---------- [cs-fixer] Use PhpUnit native assertions in filsystem checks | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA This PR change the minimal value of PhpUnit introduced in #32885 in branche 3.4. Note: `5.6` is the highest value at the time. Commits ------- 226bdd1 Use PHPunit assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the minimal value of PhpUnit introduced in #32885 in branche 3.4.
Note:
5.6is the highest value at the time.