[PhpUnitBridge] Remove calls to deprecated function assertAttributeX #32923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
commented
Aug 4, 2019
| continue; | ||
| } | ||
| $property = $reflection->getProperty($property); | ||
| $property->setAccessible(true); |
Member
Author
There was a problem hiding this comment.
I don't see how to keep the Test without reflection. (unless refactoring the way DSN is parsed or the connection is initialized, but it's not necessary IMHO)
jderusse
force-pushed
the
deprec-assertAttribute
branch
from
d68dd96 to
d098c11
Compare
jderusse
changed the title
jderusse
changed the title
nicolas-grekas
approved these changes
Aug 4, 2019
23 tasks
Member
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 4, 2019
…rtAttributeX (jderusse) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Remove calls to deprecated function assertAttributeX | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR remove unecessary call to assertAttribute and replace assertAttributeX by Reflection when no alternative is available. Commits ------- d098c11 Remove calls to deprecated function assertAttributeX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove unecessary call to assertAttribute and replace assertAttributeX by Reflection when no alternative is available.