[PhpUnitBridge] Use PHPUnit75Migration in CS fixer #32885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
csfixer-phpunit
branch
2 times, most recently
from
408792f to
8018433
Compare
jderusse
force-pushed
the
csfixer-phpunit
branch
from
8018433 to
d35ea4a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…derusse) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Polyfill the method createPartialMock | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA Provide a polyfill for `createPartialMock` required by #32885 Commits ------- a68c16d Polyfill the method createPartialMock
nicolas-grekas
force-pushed
the
csfixer-phpunit
branch
from
d35ea4a to
9fb1c42
Compare
Member
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…las-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Use PHPUnit75Migration in CS fixer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (not yet) need #32882, #32886, #32893 | Fixed tickets | #32844 | License | MIT | Doc PR | NA Bump php-cs-fixer rule to PHPUnit75Migration:risky which add - php_unit_dedicate_assert_internal_type - php_unit_expectation - php_unit_mock - php_unit_no_expectation_annotation which are (or will be) all polyfillyed - [x] need to polyfill `createPartialMock` Commits ------- 9fb1c42 Adopt `@PHPUnit55Migration:risky` rule of php-cs-fixer
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
…ecks (jderusse) This PR was merged into the 3.4 branch. Discussion ---------- [cs-fixer] Use PhpUnit native assertions in filsystem checks | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA This PR change the minimal value of PhpUnit introduced in #32885 in branche 3.4. Note: `5.6` is the highest value at the time. Commits ------- 226bdd1 Use PHPunit assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump php-cs-fixer rule to PHPUnit75Migration:risky which add
which are (or will be) all polyfillyed
createPartialMock