Skip to content

[PhpUnitBridge] Fix deprecation assertInternalType - 4.3 #32856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jderusse wants to merge 1 commit into from
Closed

[PhpUnitBridge] Fix deprecation assertInternalType - 4.3 #32856

jderusse wants to merge 1 commit into from

Conversation

@jderusse
Copy link
Member

@jderusse jderusse commented Aug 1, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR NA

This PR fixes PhpUnit deprecation :

assertInternalType() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertIsArray(), assertIsBool(), assertIsFloat(), assertIsInt(), assertIsNumeric(), assertIsObject(), assertIsResource(), assertIsString(), assertIsScalar(), assertIsCallable(), or assertIsIterable() instead

follow #32846 for 4.3 branch

@jderusse jderusse closed this Aug 1, 2019
@jderusse jderusse deleted the 4.3 branch October 15, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug PhpUnitBridge Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jderusse @carsonbot