[WebProfilerBundle] mark all classes as internal #32698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those classes are not meant as extension point
nicolas-grekas
approved these changes
Jul 24, 2019
fabpot
approved these changes
Jul 24, 2019
Member
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jul 24, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] mark all classes as internal | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | those classes are not meant as extension point Commits ------- 35b0d57 [WebProfilerBundle] mark all classes as internal
yceruto
added a commit
that referenced
this pull request
Nov 7, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [WebProfilerBundle] Clean @internal annotations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Clean remaining `@internal` added by #32698 Commits ------- 7df469b [WebProfilerBundle] Clean @internal annotations
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those classes are not meant as extension point