[ErrorRenderer] Allow disabling debug content in debug mode (preview mode) #32693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
force-pushed
the
error_renderer_x_debug
branch
from
63b57fd to
84949d4
Compare
Tobion
reviewed
Jul 24, 2019
src/Symfony/Component/ErrorRenderer/ErrorRenderer/HtmlErrorRenderer.php
Outdated
Show resolved
Hide resolved
yceruto
force-pushed
the
error_renderer_x_debug
branch
from
84949d4 to
c19d8bf
Compare
yceruto
force-pushed
the
error_renderer_x_debug
branch
from
c19d8bf to
a6bef5e
Compare
Tobion
approved these changes
Jul 24, 2019
Contributor
|
Thank you @yceruto. |
Tobion
added a commit
that referenced
this pull request
Jul 24, 2019
…ode (preview mode) (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorRenderer] Allow disabling debug content in debug mode (preview mode) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Required by #31398 to show a preview mode of the error for each content format. Usage: https://github.com/symfony/symfony/pull/31398/files#diff-9ff5216ab011f5e48c7835d4138bf825R42 Note that you can't enable the debug content in non-debug mode via `X-Debug`. I also added more tests. Commits ------- a6bef5e Allow disabling debug content in debug mode (preview mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #31398 to show a preview mode of the error for each content format.
Usage: https://github.com/symfony/symfony/pull/31398/files#diff-9ff5216ab011f5e48c7835d4138bf825R42
Note that you can't enable the debug content in non-debug mode via
X-Debug. I also added more tests.