Skip to content

Conversation

@Koc
Copy link
Contributor

@Koc Koc commented Jul 15, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Some of this translations could be missing in 4.2 also, but support of Symfony 4.2 ends in two weeks, so I think nobody cares about missing translations in it.

@peter-gribanov , @vudaltsov , @insidestyles, @stfalcon please, check also provided translations

@Koc Koc force-pushed the validator-update-ru-ua-translations-4.3 branch from 8c10047 to fe1e688 Compare July 15, 2019 20:41
@fabpot
Copy link
Member

fabpot commented Jul 15, 2019

All translations are merged into 3.4 (even for translations that are not needed for 3.4).

@Koc
Copy link
Contributor Author

Koc commented Jul 15, 2019

@fabpot So should I open PR for 4.4 branch to embed translation for #32435 also?

@fabpot
Copy link
Member

fabpot commented Jul 15, 2019

The translation for #32435 should be done in 3.4 as well

@Koc Koc force-pushed the validator-update-ru-ua-translations-4.3 branch from fe1e688 to fae418f Compare July 15, 2019 21:18
@Koc Koc requested a review from xabbuh as a code owner July 15, 2019 21:18
@Koc Koc changed the base branch from 4.3 to 3.4 July 15, 2019 21:18
@Koc
Copy link
Contributor Author

Koc commented Jul 15, 2019

Rebased on 3.4, added all missing translations.

Copy link
Contributor

@vudaltsov vudaltsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the Russian part.

@fabpot
Copy link
Member

fabpot commented Jul 16, 2019

Thank you @Koc.

@fabpot fabpot merged commit fae418f into symfony:3.4 Jul 16, 2019
fabpot added a commit that referenced this pull request Jul 16, 2019
…ns (Koc)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add missing Russian and Ukrainian translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

~~Some of this translations could be missing in 4.2 also, but [support of Symfony 4.2](https://symfony.com/roadmap/4.2) ends in two weeks, so I think nobody cares about missing translations in it.~~

@peter-gribanov , @vudaltsov , @insidestyles, @stfalcon please, check also provided translations

Commits
-------

fae418f [Validator] Add missing Russian and Ukrainian translations
@Koc Koc deleted the validator-update-ru-ua-translations-4.3 branch July 16, 2019 19:16
Copy link
Contributor

@peter-gribanov peter-gribanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russian translation is good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants