-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Validator] Add missing Russian and Ukrainian translations #32554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator] Add missing Russian and Ukrainian translations #32554
Conversation
8c10047 to
fe1e688
Compare
|
All translations are merged into 3.4 (even for translations that are not needed for 3.4). |
|
The translation for #32435 should be done in 3.4 as well |
fe1e688 to
fae418f
Compare
|
Rebased on 3.4, added all missing translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the Russian part.
|
Thank you @Koc. |
…ns (Koc) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add missing Russian and Ukrainian translations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ~~Some of this translations could be missing in 4.2 also, but [support of Symfony 4.2](https://symfony.com/roadmap/4.2) ends in two weeks, so I think nobody cares about missing translations in it.~~ @peter-gribanov , @vudaltsov , @insidestyles, @stfalcon please, check also provided translations Commits ------- fae418f [Validator] Add missing Russian and Ukrainian translations
peter-gribanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Russian translation is good 👍
Some of this translations could be missing in 4.2 also, but support of Symfony 4.2 ends in two weeks, so I think nobody cares about missing translations in it.@peter-gribanov , @vudaltsov , @insidestyles, @stfalcon please, check also provided translations