[VarDumper] Allow to configure VarDumperTestTrait casters & flags #32463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Jul 9, 2019
Member
lyrixx
left a comment
lyrixx
left a comment
There was a problem hiding this comment.
(I prefer when property declaration and their usage are sorted in the same order, but this is really a detail)
👍
ro0NL
reviewed
Jul 10, 2019
ogizanagi
commented
Jul 10, 2019
Contributor
Author
|
@nicolas-grekas : Better? :) |
nicolas-grekas
approved these changes
Jul 12, 2019
ro0NL
reviewed
Jul 12, 2019
oliverquynh
approved these changes
Jul 16, 2019
Simperfit
approved these changes
Jul 16, 2019
Member
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 17, 2019
…ers & flags (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] Allow to configure VarDumperTestTrait casters & flags | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | TODO: showcase using `setUpVarDumper` in `setUp` or in specific test cases accordingly to the use-case. `tearDownVarDumper` is automatically called after each test case. The VarDumper component is a great tool in tests to assert objects states. The ability to register custom casters on need is a nice way to control only the fields you're expecting, or a way to write concise test cases. Hence this feature allowing to configure casters specifically per test class/case. Commits ------- 613dbb2 [VarDumper] Allow to configure VarDumperTestTrait casters & flags
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setUpVarDumperinsetUpor in specific test cases accordingly to the use-case.tearDownVarDumperis automatically called after each test case.The VarDumper component is a great tool in tests to assert objects states.
The ability to register custom casters on need is a nice way to control only the fields you're expecting, or a way to write concise test cases.
Hence this feature allowing to configure casters specifically per test class/case.