[WebProfilerBundle] Deprecating templateExists method #32462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
force-pushed
the
deprecate_template_exists
branch
from
7722168 to
fba7d48
Compare
yceruto
force-pushed
the
deprecate_template_exists
branch
from
fba7d48 to
2e81e45
Compare
fabpot
approved these changes
Jul 9, 2019
Member
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jul 9, 2019
…(yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Deprecating templateExists method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | not needed Follow up #32458, so in 5.0 we can remove these methods safely. I'm not deprecating the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class is being deprecated in #31398 See also #32461 Commits ------- 2e81e45 Deprecating templateExists method
fabpot
added a commit
that referenced
this pull request
Jul 9, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [WebProfilerBundle] Removed templateExists method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | not needed Follow up #32458, since Twig 2.0 the `exists()` method is part of the `LoaderInterface`. I'm not removing the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class will be removed after #31398 See also #32462 Commits ------- 059113e Removed templateExists method
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #32458, so in 5.0 we can remove these methods safely.
I'm not deprecating the
Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()method because the whole class is being deprecated in #31398See also #32461