[DomCrawler] add a normalizeWhitespace argument to text() method #32440
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
from
81b567e to
20c2671
Compare
Contributor
Author
|
The contribution header is the same as the other PR, should it be updated too ? Edit: updated |
Simperfit
changed the title
fabpot
requested changes
Jul 9, 2019
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
from
20c2671 to
4caab39
Compare
fabpot
requested changes
Jul 9, 2019
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
2 times, most recently
from
f0531dd to
88e79ff
Compare
fabpot
requested changes
Jul 9, 2019
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
2 times, most recently
from
c33f8ca to
9526c94
Compare
nicolas-grekas
requested changes
Jul 10, 2019
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
from
9526c94 to
ccce091
Compare
nicolas-grekas
requested changes
Jul 30, 2019
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
2 times, most recently
from
37fc6ad to
0b9ee0c
Compare
nicolas-grekas
requested changes
Aug 6, 2019
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
please add a few test cases
Simperfit
changed the title
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
from
0b9ee0c to
0a1a253
Compare
Simperfit
force-pushed
the
issue-21302-rebased-updated
branch
from
0a1a253 to
f4d63fc
Compare
Simperfit
changed the title
Member
|
Please update the test case to ensure double spaces+line breaks in the middle of the text are normalized too. |
Member
|
@Simperfit Are you able to finish this PR? |
Member
|
Thank you @Simperfit. |
nicolas-grekas
force-pushed
the
issue-21302-rebased-updated
branch
from
f4d63fc to
1746718
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 27, 2019
…t() method (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler] add a normalizeWhitespace argument to text() method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #21302, #23626 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | todo <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> I've taken #24412, rebased with 4.4, fixed the comments in the PR. cc @xabbuh @stof @nicolas-grekas Commits ------- 1746718 [DomCrawler] add a value() method, normalize whitespaces
This was referenced Nov 12, 2019
Merged
Merged
Contributor
|
For the record, this mode became the default in Symfony 5 (see #34151). |
Contributor
|
Also worth noting this follow‑up: #47175, which fixed locale‑sensitivity issues in the whitespace normalization at hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken #24412, rebased with 4.4, fixed the comments in the PR.
cc @xabbuh @stof @nicolas-grekas