[Stopwatch] Fix missing deprecations #32428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 8, 2019
jschaedl
reviewed
Jul 8, 2019
src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.php
Show resolved
Hide resolved
Member
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Fix missing deprecations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | no needed Fix #32408 Commits ------- 527bf89 Fix missing deprecations
| public function open($id) | ||
| { | ||
| if (null === $session = $this->get($id)) { | ||
| if (null === $id || null === $session = $this->get($id)) { |
Member
There was a problem hiding this comment.
I'm reverting this change, it's a BC break caught by the test suite.
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] fix tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This part of #32428 is for 3.4 Commits ------- 6eee2a8 [HttpKernel] fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32408