Skip to content

[Validator] Fix tests #32372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jul 4, 2019
Merged

[Validator] Fix tests #32372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/ConstraintViolation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function __toString()
$class .= '.';
}

if ('' !== $code = $this->code) {
if ('' !== $code = (string) $this->code) {
$code = ' (code '.$code.')';
}

Expand Down
6 changes: 1 addition & 5 deletions src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ public function testToStringOmitsEmptyCodes()
$this->assertSame($expected, (string) $violation);
}

/**
* @group legacy
* @expectedDeprecation Not using a string as the error code in Symfony\Component\Validator\ConstraintViolation::__construct() is deprecated since Symfony 4.4. A type-hint will be added in 5.0.
*/
public function testNonStringCode()
{
$violation = new ConstraintViolation(
Expand All @@ -126,6 +122,6 @@ public function testNonStringCode()
42
);

self::assertSame(42, $violation->getCode());
self::assertSame('42', $violation->getCode());
}
}
7 changes: 1 addition & 6 deletions src/Symfony/Component/Validator/Tests/Violation/ConstraintViolationBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,13 @@

class ConstraintViolationBuilderTest extends TestCase
{
/**
* @group legacy
* @expectedDeprecation Not using a string as the error code in Symfony\Component\Validator\Violation\ConstraintViolationBuilder::setCode() is deprecated since Symfony 4.4. A type-hint will be added in 5.0.
* @expectedDeprecation Not using a string as the error code in Symfony\Component\Validator\ConstraintViolation::__construct() is deprecated since Symfony 4.4. A type-hint will be added in 5.0.
*/
public function testNonStringCode()
{
$constraintViolationList = new ConstraintViolationList();
(new ConstraintViolationBuilder($constraintViolationList, new ConstraintA(), 'invalid message', [], null, 'foo', 'baz', new IdentityTranslator()))
->setCode(42)
->addViolation();

self::assertSame(42, $constraintViolationList->get(0)->getCode());
self::assertSame('42', $constraintViolationList->get(0)->getCode());
}
}