[HttpFoundation] Accept must take the lead for Request::getPreferredFormat() #32348
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
fix-32344
branch
2 times, most recently
from
301d441 to
fe05ece
Compare
yceruto
requested changes
Jul 3, 2019
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
Yes, I agree that Accept must win when both headings are provided, but _format attribute must win over Accept otherwise we are breaking things.
yceruto
reviewed
Jul 3, 2019
fabpot
approved these changes
Jul 4, 2019
Member
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2019
…tPreferredFormat() (dunglas) This PR was squashed before being merged into the 4.4 branch (closes #32348). Discussion ---------- [HttpFoundation] Accept must take the lead for Request::getPreferredFormat() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Follow up PR to #32344: if both `Accept` and `Content-Type` are defined, `Accept` must take the lead because it explicitly tells what format the client expect as a response. Before: ``` $ curl -H 'Accept: application/json' -H 'Content-Type: text/xml' -i 'https://127.0.0.1:8000/userinfo' [snip] content-type: text/xml ``` After: ``` $ curl -H 'Accept: application/json' -H 'Content-Type: text/xml' -i 'https://127.0.0.1:8000/userinfo' [snip] content-type: application/json ``` Actually, I'm not sure that inferring the content type of the response using the `Content-Type` provided for the request body is a good idea. The HTTP RFC explicitly states that `Accept` must be used to hint a preferred response format (`Content-Type` on the request indicates the type of associated its the body). I would be in favor of being more conservative: use `Accept` if provided (a best practice anyway), and fallback to the default value (HTML by default) otherwise. WDYT? Commits ------- 60d997d [HttpFoundation] Accept must take the lead for Request::getPreferredFormat()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #32344: if both
AcceptandContent-Typeare defined,Acceptmust take the lead because it explicitly tells what format the client expect as a response.Before:
After:
Actually, I'm not sure that inferring the content type of the response using the
Content-Typeprovided for the request body is a good idea. The HTTP RFC explicitly states thatAcceptmust be used to hint a preferred response format (Content-Typeon the request indicates the type of associated its the body). I would be in favor of being more conservative: useAcceptif provided (a best practice anyway), and fallback to the default value (HTML by default) otherwise. WDYT?