[Security][Http] Add type-hints #32314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreia
commented
Jul 2, 2019
derrabus
requested changes
Jul 2, 2019
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
Member
|
Please also check the failing unit tests. They are related to your changes. |
57 tasks
linaori
reviewed
Jul 3, 2019
Contributor
linaori
left a comment
linaori
left a comment
There was a problem hiding this comment.
Code wise everything looks fine, got a few remarks on docblocks and return types that could be improved upon, but shouldn't be blocking this PR in my opinion
src/Symfony/Component/Security/Http/Authentication/AuthenticationUtils.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Authentication/DefaultAuthenticationSuccessHandler.php
Outdated
Show resolved
Hide resolved
derrabus
requested changes
Jul 3, 2019
Member
|
@andreia Can you have a look at the remaining comment here? Thank you. |
Contributor
Author
|
@fabpot Done |
fabpot
requested changes
Aug 4, 2019
src/Symfony/Component/Security/Http/RememberMe/TokenBasedRememberMeServices.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/RememberMe/TokenBasedRememberMeServices.php
Show resolved
Hide resolved
chalasr
approved these changes
Aug 5, 2019
Member
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
I fixed fabbot and removed some ? for args which have null as default value. Ready
Tobion
reviewed
Aug 5, 2019
fabpot
requested changes
Aug 6, 2019
Tobion
reviewed
Aug 7, 2019
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
Aug 7, 2019
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
Tobion
approved these changes
Aug 7, 2019
Member
|
Thank you @andreia. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security][Http] Add type-hints | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | This PR adds type-hints to the HTTP Security sub-component. Commits ------- 6bae9bc [Security][Http] Add type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type-hints to the HTTP Security sub-component.