[DependencyInjection] Removed unused field #32306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Jul 2, 2019
Simperfit
approved these changes
Jul 2, 2019
lyrixx
approved these changes
Jul 2, 2019
Member
lyrixx
left a comment
lyrixx
left a comment
There was a problem hiding this comment.
👍 Did you check for other unused property like that?
Contributor
|
Yes xD |
yceruto
approved these changes
Jul 2, 2019
xabbuh
approved these changes
Jul 2, 2019
fabpot
approved these changes
Jul 3, 2019
Member
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [DependencyInjection] Removed unused field | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A A minor issue I discovered while analyzing the DI component for #32238: `AnalyzeServiceReferencesPass` defines a private field `$expressionLanguage` that is not used. Commits ------- 5865140 Removed unused field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor issue I discovered while analyzing the DI component for #32238:
AnalyzeServiceReferencesPassdefines a private field$expressionLanguagethat is not used.