Skip to content

[Form] remove form type validation due to typehints #32178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Jun 26, 2019
Merged

[Form] remove form type validation due to typehints #32178

fabpot merged 1 commit into from
Jun 26, 2019

Conversation

@Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 25, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@Tobion Tobion requested a review from xabbuh as a code owner June 25, 2019 22:59
@Tobion Tobion mentioned this pull request Jun 25, 2019
Merged
@Tobion Tobion force-pushed the form-validate-name branch from 51d1711 to ba2b5c1 Compare June 25, 2019 23:02
@fabpot
Copy link
Member

fabpot commented Jun 26, 2019

Thank you @Tobion.

@fabpot fabpot merged commit ba2b5c1 into symfony:master Jun 26, 2019
fabpot added a commit that referenced this pull request Jun 26, 2019
@fabpot
minor #32178 [Form] remove form type validation due to typehints (Tob…
71525d4 
…ion)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] remove form type validation due to typehints

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

ba2b5c1 [Form] remove form type validation due to typehints
@xabbuh xabbuh added this to the 5.0 milestone Jun 26, 2019
@Tobion Tobion deleted the form-validate-name branch June 26, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

No one assigned

Labels

Form Status: Reviewed

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Tobion @fabpot @xabbuh @carsonbot