Skip to content

[Validator] Add ExpressionValidator typehint & remove deprecation #32128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Jun 22, 2019
Merged

[Validator] Add ExpressionValidator typehint & remove deprecation #32128

fabpot merged 1 commit into from
Jun 22, 2019

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jun 21, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32041
License MIT
Doc PR N/A

@xabbuh xabbuh added this to the 5.0 milestone Jun 21, 2019
@fabpot
Copy link
Member

fabpot commented Jun 22, 2019

Thank you @ogizanagi.

@fabpot fabpot merged commit e4c4d2d into symfony:master Jun 22, 2019
fabpot added a commit that referenced this pull request Jun 22, 2019
@fabpot
minor #32128 [Validator] Add ExpressionValidator typehint & remove de…
2f9e69e 
…precation (ogizanagi)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Validator] Add ExpressionValidator typehint & remove deprecation

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no  <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32041   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

e4c4d2d [Validator] Add ExpressionValidator typehint & remove deprecation
@ogizanagi ogizanagi deleted the rm/validator/expr_deprec branch June 22, 2019 08:32
@ogizanagi ogizanagi restored the rm/validator/expr_deprec branch July 4, 2019 15:33
@ogizanagi ogizanagi deleted the rm/validator/expr_deprec branch July 4, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@Simperfit Simperfit Simperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Reviewed Validator

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi @fabpot @xabbuh @Simperfit @carsonbot