[FrameworkBundle] tag the FileType service as a form type #32116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Jun 20, 2019
fabpot
approved these changes
Jun 20, 2019
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 20, 2019
…(xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] tag the FileType service as a form type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #32045 | License | MIT | Doc PR | In #30961 we undeprecated the `form.type.file` service as we need to pass the translator to the form type. But we forgot to add back the `form.type` tag which means that the form registry actually never used our service but instantiated the `FileType` itself and thus the type was never able to use a translator. Commits ------- ea5b1f4 tag the FileType service as a form type
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30961 we undeprecated the
form.type.fileservice as we need to pass the translator to the form type. But we forgot to add back theform.typetag which means that the form registry actually never used our service but instantiated theFileTypeitself and thus the type was never able to use a translator.