[Validator] Deprecate unused arg in ExpressionValidator #32041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
changed the title
fabpot
approved these changes
Jun 14, 2019
Member
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2019
…r (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Deprecate unused arg in ExpressionValidator | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> Time to deprecate this unused first argument? Commits ------- 0c0978c [Validator] Deprecate unused arg in ExpressionValidator
fabpot
added a commit
that referenced
this pull request
Jun 22, 2019
…precation (ogizanagi) This PR was merged into the 5.0-dev branch. Discussion ---------- [Validator] Add ExpressionValidator typehint & remove deprecation | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32041 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- e4c4d2d [Validator] Add ExpressionValidator typehint & remove deprecation
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to deprecate this unused first argument?