[OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() #31950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
the idea was for e.g. vendors using So it's a feature .. kinda :) |
Member
Author
|
Does this have to be at the |
Contributor
I think yes, because that's what you typehint for: $resolver->setDefaults([
'a' => function (Options $options) {
$b = $options->offsetGet('b', false); // never triggers
$c = $options['c']; // always triggers
},
]); |
yceruto
approved these changes
Jun 8, 2019
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
Yes, the new argument is an implementation detail of the OptionsResolver. I agree it shouldn't be part of the interface.
Member
|
This was about documentation only :) (for IDEs mainly) |
Member
|
should be target 4.2 |
nicolas-grekas
force-pushed
the
opt-no-deprec
branch
from
9a422cd to
adc7e6a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 9, 2019
…ons::offsetGet() (nicolas-grekas) This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #31950). Discussion ---------- [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been added by @yceruto in #28878 but it doesn't make sense to me: the interface has no concept if deprecation (`OptionsResolver` has!) Commits ------- adc7e6a [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been added by @yceruto in #28878 but it doesn't make sense to me: the interface has no concept if deprecation (
OptionsResolverhas!)