[WebProfilerBundle] Select default theme based on user preferences #31919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 7, 2019
ogizanagi
approved these changes
Jun 7, 2019
Contributor
noniagriconomie
left a comment
noniagriconomie
left a comment
There was a problem hiding this comment.
Small yet big change :)
vudaltsov
approved these changes
Jun 11, 2019
Member
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2019
… preferences (javiereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] Select default theme based on user preferences | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | (not needed) This is the same we recently added to symfony.com website. It works on latest versions of Firefox and Safari only (Chrome will add support soon). Commits ------- 0fc0a34 [WebProfilerBundle] Select default theme based on user preferences
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same we recently added to symfony.com website. It works on latest versions of Firefox and Safari only (Chrome will add support soon).