[HttpKernel] deprecate the usage of the deprecated events to ease deleting them #31886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deletion of them
Simperfit
force-pushed
the
deprecation/deprecate-the-event-to-ease-the-deletion-of-them
branch
from
e1153f0 to
fde6c62
Compare
Member
|
That's a BC break, not possible. |
Simperfit
deleted the
deprecation/deprecate-the-event-to-ease-the-deletion-of-them
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix the tests in #31672, since all the class has been made final since 4.3, we don't have any problem changing the type hint in 4.4 and then using the right type hint in 5.0.