Rename the Symfony Mailer service implementation to avoid conflict with SwitMailer #31854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
changed the title
Member
|
I hit this too :) composer create-project symfony/website-skeleton sf43w
cd sf43w
composer require symfony/mailer
bin/console make:command tito
# type-hint the new MailerInterface => BOOM |
fabpot
approved these changes
Jun 5, 2019
Member
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
…conflict with SwitMailer (tgalopin) This PR was merged into the 4.3 branch. Discussion ---------- Rename the Symfony Mailer service implementation to avoid conflict with SwitMailer | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When you install Symfony Mailer as well as SwitMailer and try to typehint MailerInterface, the autowiring alias is aliased to the "mailer" service which is overriden by SwitMailer, thus making the injection fail. Commits ------- e7c96d3 Rename the Symfony Mailer service config to avoid conflict with SwitMailer
Merged
Contributor
|
switmailer typo in the title, also in 4.3.1 changelog |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 2, 2020
This PR was merged into the 4.3 branch. Discussion ---------- Update service id of the MailerInterface The service id of the MailerInterface was changed in symfony/symfony#31854 to avoid an conflict with SwiftMailer Commits ------- 93668de Update service id of the MailerInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you install Symfony Mailer as well as SwitMailer and try to typehint MailerInterface, the autowiring alias is aliased to the "mailer" service which is overriden by SwitMailer, thus making the injection fail.