Skip to content

[HttpClient] prevent installation of contracts 1.2 #31842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh wants to merge 1 commit into from
Closed

[HttpClient] prevent installation of contracts 1.2 #31842

xabbuh wants to merge 1 commit into from

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.3 milestone Jun 4, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 4, 2019

Hey, no :) Why?

@xabbuh
Copy link
Member Author

xabbuh commented Jun 4, 2019

In 4.3 we do not implement the cancel() method added in #31831 (see the currently failing tests).

@xabbuh
Copy link
Member Author

xabbuh commented Jun 4, 2019

https://travis-ci.org/symfony/symfony/jobs/541145074#L4102

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 4, 2019

Or we could remove the method from the interface and turn it into an @method annotation.
(+ skip in HttpClientTestCase)
WDYT?

This was referenced Jun 4, 2019
Closed
Merged
@xabbuh
Copy link
Member Author

xabbuh commented Jun 5, 2019

closing in favour of #31850

@xabbuh xabbuh closed this Jun 5, 2019
@xabbuh xabbuh deleted the pr-31831 branch June 5, 2019 07:32
fabpot added a commit that referenced this pull request Jun 5, 2019
@fabpot
bug #31850 [HttpClient] add $response->cancel() (nicolas-grekas)
e5b082a 
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] add $response->cancel()

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#11668

An alternative to #31845 and #31842.
Same as  #31831 but considered as a bug fix (at the Contracts level), thus for 4.3.
I think we're early enough since 4.3/1.1 to do it.
That will save us some headaches in the short term.

Commits
-------

c402418 [HttpClient] add $response->cancel()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug HttpClient Status: Needs Review

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh @nicolas-grekas @carsonbot