[Translator] Collect locale details earlier in the process #31815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 3, 2019
Member
|
Thank you @pierredup. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 3, 2019
… (pierredup) This PR was merged into the 4.3 branch. Discussion ---------- [Translator] Collect locale details earlier in the process | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31600 | License | MIT | Doc PR | N/A The [LocaleAwareListener](https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php) class reverts the locale back to the default locale when the request has finished. But the `TranslationDataCollector` only collects the locale in `lateCollect`, which only happens when the kernel terminates. This means the locale is reverted back to the default by the time the collector runs. The PR moves the `locale` and `fallback_locales` from `lateCollect` to `collect`, so that the information can be captured earlier, before the `LocaleAwareListener` is run. Commits ------- 5c394ee Collect locale details earlier in the process in TranslationDataCollector
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocaleAwareListener class reverts the locale back to the default locale when the request has finished. But the
TranslationDataCollectoronly collects the locale inlateCollect, which only happens when the kernel terminates. This means the locale is reverted back to the default by the time the collector runs.The PR moves the
localeandfallback_localesfromlateCollecttocollect, so that the information can be captured earlier, before theLocaleAwareListeneris run.