[DoctrineBridge] don't add embedded properties to wrapping class metadata #31811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 3, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31775 |
| License | MIT |
| Doc PR |
Korbeil
approved these changes
Jun 3, 2019
Contributor
Korbeil
left a comment
Korbeil
left a comment
There was a problem hiding this comment.
Looks perfect, thanks ! 😃
xabbuh
changed the title
phansys
approved these changes
Jun 3, 2019
fabpot
approved these changes
Jun 4, 2019
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 4, 2019
… class metadata (xabbuh) This PR was merged into the 4.3 branch. Discussion ---------- [DoctrineBridge] don't add embedded properties to wrapping class metadata | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31775 | License | MIT | Doc PR | Commits ------- 56fe025 don't add embedded properties to wrapping class metadata
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.