[DomCrawler] Fix type error with null Form::$currentUri #31757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
May 30, 2019
chalasr
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31644 |
| License | MIT |
| Doc PR | n/a |
chalasr
commented
May 30, 2019
| * @param string $currentUri The URI of the page where the form is embedded | ||
| * @param string $method The method to use for the link (if null, it defaults to the method defined by the form) | ||
| * @param string $baseHref The URI of the <base> used for relative links, but not for empty action | ||
| * |
Member
Author
There was a problem hiding this comment.
I did not fix the docblock as there are plenty of missing |null across the component codebase, should be done globally on 3.4.
derrabus
approved these changes
May 31, 2019
Member
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
May 31, 2019
…halasr) This PR was merged into the 4.2 branch. Discussion ---------- [DomCrawler] Fix type error with null Form::$currentUri | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31644 | License | MIT | Doc PR | n/a Commits ------- e48d5d0 [DomCrawler] Fix type error with null Form::$currentUri
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.