[Messenger] Inject RoutableMessageBus instead of bus locator #31748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
May 30, 2019
chalasr
commented
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31741 |
| License | MIT |
| Doc PR | n/a |
chalasr
force-pushed
the
inject-routable-messagebus
branch
2 times, most recently
from
f8b2df9 to
b0a4289
Compare
Member
Author
|
Fabbot wants me to split |
weaverryan
reviewed
May 30, 2019
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
inject-routable-messagebus
branch
2 times, most recently
from
853449f to
dc95fa5
Compare
Tobion
reviewed
May 30, 2019
src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
inject-routable-messagebus
branch
2 times, most recently
from
53183c0 to
8b0342a
Compare
Tobion
reviewed
May 31, 2019
chalasr
force-pushed
the
inject-routable-messagebus
branch
from
8b0342a to
91817e4
Compare
Tobion
approved these changes
May 31, 2019
fabpot
approved these changes
May 31, 2019
Member
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 31, 2019
…or (chalasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Inject RoutableMessageBus instead of bus locator | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31741 | License | MIT | Doc PR | n/a Commits ------- 91817e4 [Messenger] Inject RoutableMessageBus instead of bus locator
fabpot
added a commit
that referenced
this pull request
Jun 1, 2019
…MessagesCommand's constructor (chalasr) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand's constructor | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Continuation of #31748 Commits ------- 1409338 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.