[HttpKernel] The methods of the deprecated event should be final #31701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Returns the current controller. | ||
| * | ||
| * @final since Symfony 4.4 |
Member
There was a problem hiding this comment.
sorry if that wasn't clear, but this is needed only for NON deprecated classes.
Contributor
Author
|
They extends these, so Do i copy past them now ?
Le mer. 29 mai 2019 à 19:40, Nicolas Grekas <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php
<#31701 (comment)>:
> @@ -31,6 +31,8 @@ public function __construct(HttpKernelInterface $kernel, callable $controller, R
/**
* Returns the current controller.
*
+ * @Final since Symfony 4.4
sorry if that wasn't clear, but this is needed only for NON deprecated
classes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31701?email_source=notifications&email_token=AA2KV4UD7VKR6VYWIV7QCF3PX252NA5CNFSM4HQO6DW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2BDSPY#pullrequestreview-243415359>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2KV4RU2DD6YIDIFNSKFK3PX252NANCNFSM4HQO6DWQ>
.
|
Member
|
Oh, I understand. Then the changelog/upgrade should mention the child (non-deprecated) classes. |
| HttpKernel | ||
| ---------- | ||
| * The method `FilterControllerArgumentsEvent::getArguments()` marked final. |
Member
|
oh wait sorry I forgot about #30323 which will allow this everywhere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs allows to change the return types in 5.0 of the differents methods of the deprecated events class.
As said in #31672 (comment)