Skip to content

[Serializer] Throw exception on invalid normalizers/encoders passed to Serializer #31693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
May 29, 2019
Merged

[Serializer] Throw exception on invalid normalizers/encoders passed to Serializer #31693

nicolas-grekas merged 1 commit into from
May 29, 2019

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27819
License MIT
Doc PR N/A

As planned in #27819

@ogizanagi ogizanagi requested a review from dunglas as a code owner May 29, 2019 14:39
@ogizanagi ogizanagi added this to the 5.0 milestone May 29, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 29, 2019

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 5ab6ad4 into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
@nicolas-grekas
minor #31693 [Serializer] Throw exception on invalid normalizers/enco…
cc44d66 
…ders passed to Serializer (ogizanagi)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Serializer] Throw exception on invalid normalizers/encoders passed to Serializer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27819   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

As planned in #27819

Commits
-------

5ab6ad4 [Serializer] Throw exception on invalid normalizers/encoders passed to Serializer
@ogizanagi ogizanagi deleted the rm_deprec/serializer/normalizer_interface branch May 29, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas Awaiting requested review from dunglas

Assignees

No one assigned

Labels

Serializer Status: Needs Review

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ogizanagi @nicolas-grekas @carsonbot