[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms #31665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Status: Needs Work |
yceruto
force-pushed
the
rm_intl_form_type_deprecation
branch
2 times, most recently
from
bbe40d5 to
08307c3
Compare
Member
Author
|
(Tests failures unrelated) Status: Needs Review |
nicolas-grekas
requested changes
May 29, 2019
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
please move the added static to a PR for 4.4
yceruto
force-pushed
the
rm_intl_form_type_deprecation
branch
from
08307c3 to
b22cbf4
Compare
nicolas-grekas
approved these changes
May 29, 2019
Member
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
May 29, 2019
…nterface in intl forms (yceruto) This PR was merged into the 5.0-dev branch. Discussion ---------- [Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See previous PR #26825 (4.1) Commits ------- b22cbf4 Remove deprecated implementation of ChoiceLoaderInterface in intl forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See previous PR #26825 (4.1)