[FrameworkBundle] fix named autowiring aliases for TagAwareCacheInterface #31591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
May 22, 2019
Simperfit
reviewed
May 22, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
fwb-cache-tagautow
branch
from
d3d5137 to
decd87b
Compare
nicolas-grekas
force-pushed
the
fwb-cache-tagautow
branch
from
decd87b to
d9082c2
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2019
…eCacheInterface (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] fix named autowiring aliases for TagAwareCacheInterface | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Doing a demo today, I realized that named autowiring aliases are missing for `TagAwareCacheInterface`, and that existing ones point to the wrong service. Here is the fix. Commits ------- d9082c2 [FrameworkBundle] fix named autowiring aliases for TagAwareCacheInterface
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a demo today, I realized that named autowiring aliases are missing for
TagAwareCacheInterface, and that existing ones point to the wrong service. Here is the fix.