Skip to content

Conversation

@Simperfit
Copy link
Contributor

@Simperfit Simperfit commented May 22, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR

Fix just some phpdocs highlighted by @nicolas-grekas in #31547.

@Simperfit Simperfit changed the title minor: fix phpdocs in the ldap component [Ldap] minor: fix phpdocs in the ldap component May 22, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 22, 2019
@nicolas-grekas
Copy link
Member

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit 721915f into symfony:3.4 May 22, 2019
nicolas-grekas added a commit that referenced this pull request May 22, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Ldap] minor: fix phpdocs in the ldap component

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Fix just some phpdocs highlighted by @nicolas-grekas in #31547.

Commits
-------

721915f minor: fix phpdocs in the ldap component
@Simperfit Simperfit deleted the minor/ldap-fix-phpdoc branch June 12, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants