[Monolog] Setup the LoggerProcessor after all other processor #31509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 21, 2019
Simperfit
approved these changes
May 21, 2019
ogizanagi
approved these changes
May 23, 2019
Contributor
ogizanagi
left a comment
ogizanagi
left a comment
There was a problem hiding this comment.
Tested and validated 👍
lyrixx
added a commit
that referenced
this pull request
Jun 3, 2019
…ocessor (lyrixx) This PR was merged into the 4.4 branch. Discussion ---------- [Monolog] Setup the LoggerProcessor after all other processor | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27426 | License | MIT | Doc PR | --- This is a bit strange but [`Monolog\Processor::pushProcessor()`](https://github.com/Seldaek/monolog/blob/ebb804e432e8fe0fe96828f30d89c45581d36d07/src/Monolog/Logger.php#L224-L229) **prepend** the processor to the stack. Since the Compiler Pass has a low priority, the `DebugProcessor` is always the last one to be added to the stack, so the first one in it. Commits ------- 429307d [Monolog] Setup the LoggerProcessor after all other processor
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit strange but
Monolog\Processor::pushProcessor()prepend the processor to the stack.Since the Compiler Pass has a low priority, the
DebugProcessoris alwaysthe last one to be added to the stack, so the first one in it.