[PropertyAccess] Add missing property to PropertyAccessor #31477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vudaltsov
commented
May 11, 2019
vudaltsov
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
fabpot
requested changes
May 11, 2019
Contributor
Author
|
Status: Needs Review |
Simperfit
approved these changes
May 12, 2019
Contributor
Simperfit
left a comment
Simperfit
left a comment
There was a problem hiding this comment.
don't we have a test case for the exception ?
nicolas-grekas
approved these changes
May 12, 2019
nicolas-grekas
force-pushed
the
property-accessor-fix
branch
from
5290750 to
b1d3736
Compare
Member
|
Thank you @vudaltsov. |
nicolas-grekas
added a commit
that referenced
this pull request
May 12, 2019
…(vudaltsov) This PR was squashed before being merged into the 4.2 branch (closes #31477). Discussion ---------- [PropertyAccess] Add missing property to PropertyAccessor | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- b1d3736 [PropertyAccess] Add missing property to PropertyAccessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.