[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password #30898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 6, 2019
Contributor
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
A test case would be nice
dbrumann
approved these changes
Apr 6, 2019
tgalopin
force-pushed
the
pwned-convert-encoding
branch
from
a1be3d5 to
76fa504
Compare
ostrolucky
suggested changes
Apr 6, 2019
Contributor
ostrolucky
left a comment
ostrolucky
left a comment
There was a problem hiding this comment.
I don't think it makes too much sense to make this configurable. People who don't use UTF-8 should change internal_encoding php.ini setting
maxhelias
approved these changes
Apr 6, 2019
carsonbot
added
Status: Reviewed
Status: Needs Work
and removed
Status: Needs Work
Status: Reviewed
labels
Member
|
FrameworkBundle should define a service for that constraint validator, passing |
Contributor
Author
|
@stof that's the aim, but it can be the subject of another PR IMO. |
tgalopin
force-pushed
the
pwned-convert-encoding
branch
from
76fa504 to
239810d
Compare
Contributor
Author
|
Updated |
fabpot
approved these changes
Apr 6, 2019
tgalopin
changed the title
tgalopin
changed the title
tgalopin
force-pushed
the
pwned-convert-encoding
branch
from
239810d to
bc0ba26
Compare
Contributor
Author
|
Based on #30889, otherwise ready to review. |
Member
|
@tgalopin Can you rebase? |
tgalopin
force-pushed
the
pwned-convert-encoding
branch
from
bc0ba26 to
4f74a33
Compare
tgalopin
changed the title
Contributor
Author
|
Updated |
OskarStark
reviewed
Apr 6, 2019
src/Symfony/Bundle/FrameworkBundle/Resources/config/validator.xml
Outdated
Show resolved
Hide resolved
tgalopin
force-pushed
the
pwned-convert-encoding
branch
from
4f74a33 to
c5cd75d
Compare
Contributor
Author
|
Updated |
nicolas-grekas
approved these changes
Apr 6, 2019
… non UTF-8 password
fabpot
force-pushed
the
pwned-convert-encoding
branch
from
c5cd75d to
8ac712b
Compare
Member
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…ndle and handle non UTF-8 password (tgalopin) This PR was squashed before being merged into the 4.3-dev branch (closes #30898). Discussion ---------- [Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30870 | License | MIT | Doc PR | - Live from #eu-fossa Fix #30870 Commits ------- 8ac712b [Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live from #eu-fossa
Fix #30870